dataflow: update Dockerfile and modularize tests #5692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: dataflow
added 15 commits
April 13, 2021 15:36
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
davidcavazos
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
added 4 commits
April 29, 2021 10:36
…hon-docs-samples into dataflow-flex-templates
…amples into dataflow-flex-templates
snippet-bot
bot
removed
the
snippet-bot:force-run
added 11 commits
June 1, 2021 16:24
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
Author
|
It looks like tests are passing. It now waits until the job is running (typically 2-3 minutes), then waits 1 minute for data to come in, and cancels the job. |
Author
|
@leahecole @dandhlee tests are passing, and comments addressed. If there are no other comments, this might be ready to merge :) |
leahecole
approved these changes
Jun 4, 2021
Collaborator
|
Dan is OOO today but he'll look when he's back! |
dandhlee
approved these changes
Jun 7, 2021
Collaborator
dandhlee
left a comment
dandhlee
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment below. Thank you!
Author
|
All tests are passing. I'll merge this for now to unblock writing other tests. If we want to revisit and remove the unused utility function, I'll do it in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the Dockerfile, but while doing that I updated the test to make it e2e and actually test the image creation. There's been a lot of code duplication in tests so I tried to modularize common functions into their own file. I'll migrate other tests to use that module later on.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)